Bug 140105

Summary:

Stop including PluginView.h from cross platform WebCore code

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

140118, 140120

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Anders Carlsson 2015-01-05 16:57:45 PST

Stop including PluginView.h from cross platform WebCore code

Comment 1 Anders Carlsson 2015-01-05 16:58:48 PST

Created attachment 244017 [details]
Patch

Comment 2 WebKit Commit Bot 2015-01-05 17:00:41 PST

Attachment 244017 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/NP_jsobject.cpp:254:  _NPN_Evaluate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2015-01-05 17:12:02 PST

Created attachment 244018 [details]
Patch

Comment 4 WebKit Commit Bot 2015-01-05 17:14:42 PST

Attachment 244018 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/NP_jsobject.cpp:254:  _NPN_Evaluate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Anders Carlsson 2015-01-05 17:23:41 PST

Committed r177941: <http://trac.webkit.org/changeset/177941>