Bug 140105

Summary: Stop including PluginView.h from cross platform WebCore code
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 140118, 140120    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Anders Carlsson
Reported 2015-01-05 16:57:45 PST
Stop including PluginView.h from cross platform WebCore code
Attachments
Patch (6.25 KB, patch)
2015-01-05 16:58 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (6.61 KB, patch)
2015-01-05 17:12 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-01-05 16:58:48 PST
Created attachment 244017 [details] Patch
WebKit Commit Bot
Comment 2 2015-01-05 17:00:41 PST
Attachment 244017 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/NP_jsobject.cpp:254: _NPN_Evaluate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2015-01-05 17:12:02 PST
Created attachment 244018 [details] Patch
WebKit Commit Bot
Comment 4 2015-01-05 17:14:42 PST
Attachment 244018 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/NP_jsobject.cpp:254: _NPN_Evaluate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2015-01-05 17:23:41 PST
Committed r177941: <http://trac.webkit.org/changeset/177941>
Note You need to log in before you can comment on or make changes to this bug.