Bug 140067

Summary:

[Linux] SeccompFilters: whitelist all NPAPI plugin directories

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKit2

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, mcatanzaro, tmpsantos, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

140066

Bug Blocks:

110014, 140068

Attachments:

Description	Flags
Patch	none
[Linux] SeccompFilters: whitelist all NPAPI plugin directories	none
[Linux] SeccompFilters: whitelist all NPAPI plugin directories	none
Patch	none

Description Michael Catanzaro 2015-01-04 19:25:37 PST

Whitelist all directories that we search for NPAPI plugins.

Comment 1 Michael Catanzaro 2015-01-04 19:35:45 PST

Created attachment 243954 [details]
Patch

Comment 2 Michael Catanzaro 2015-03-23 15:56:55 PDT

Created attachment 249295 [details]
[Linux] SeccompFilters: whitelist all NPAPI plugin directories

Comment 3 Michael Catanzaro 2015-07-13 08:34:17 PDT

Created attachment 256703 [details]
[Linux] SeccompFilters: whitelist all NPAPI plugin directories

Comment 4 Michael Catanzaro 2015-07-14 07:35:42 PDT

Comment on attachment 256703 [details]
[Linux] SeccompFilters: whitelist all NPAPI plugin directories

(Looks like I need to update the copyright years in this patch.)

Comment 5 Zan Dobersek 2015-07-14 08:36:53 PDT

Comment on attachment 256703 [details]
[Linux] SeccompFilters: whitelist all NPAPI plugin directories

View in context: https://bugs.webkit.org/attachment.cgi?id=256703&action=review

> Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp:37
> +    Vector<String> result;

This could be static, with the method returning a reference to the object, but it's not terribly important since it probably doesn't get called frequently.

Comment 6 Michael Catanzaro 2015-07-14 12:09:06 PDT

Created attachment 256784 [details]
Patch

Comment 7 WebKit Commit Bot 2015-07-14 13:07:22 PDT

Comment on attachment 256784 [details]
Patch

Clearing flags on attachment: 256784

Committed r186810: <http://trac.webkit.org/changeset/186810>

Comment 8 WebKit Commit Bot 2015-07-14 13:07:25 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Michael Catanzaro 2015-07-14 13:09:24 PDT

(In reply to comment #5)
> > Source/WebKit2/Shared/Plugins/unix/PluginSearchPath.cpp:37
> > +    Vector<String> result;
> 
> This could be static, with the method returning a reference to the object,
> but it's not terribly important since it probably doesn't get called
> frequently.

Ahhh, missed that comment, I can do it in a follow-up.

Comment 10 Michael Catanzaro 2015-07-14 13:18:56 PDT

(In reply to comment #9)
> Ahhh, missed that comment, I can do it in a follow-up.

I think I slightly prefer to not make it a static reference, since it's thread-safe this way. Also so that we don't have to change PluginInfoStore::pluginsDirectories (for us and for the Mac port) where it would otherwise get copied.

Comment 11 Zan Dobersek 2015-07-15 03:03:13 PDT

(In reply to comment #10)
> (In reply to comment #9)
> > Ahhh, missed that comment, I can do it in a follow-up.
> 
> I think I slightly prefer to not make it a static reference, since it's
> thread-safe this way. Also so that we don't have to change
> PluginInfoStore::pluginsDirectories (for us and for the Mac port) where it
> would otherwise get copied.

OK, not a big issue.