Bug 140061

Summary:

fast/events/before-unload-adopt-subframe-to-outside.html is flaky with ASan

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, darin, koivisto, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	darin: review+, ap: commit-queue-
Archive of layout-test-results from ews103 for mac-mountainlion	none
Archive of layout-test-results from ews106 for mac-mountainlion-wk2	none
proposed fix	none

Description Alexey Proskuryakov 2015-01-04 16:06:22 PST

I think that this is an issue with trailing whitespace similar to one in bug 126169. There is an iframe appended to body while an inline script runs, and a newline after </script> is parsed when the iframe is already in DOM tree. After that, another iframe is added. Depending on whether a layout happens before the second iframe is added, we get different render trees in the end.

Comment 1 Alexey Proskuryakov 2015-01-04 16:09:10 PST

Created attachment 243946 [details]
proposed fix

Comment 2 Alexey Proskuryakov 2015-01-04 16:28:02 PST

Comment on attachment 243946 [details]
proposed fix

Hmm, release builds seem unhappy about this change :(

Comment 3 Build Bot 2015-01-04 16:30:31 PST

Comment on attachment 243946 [details]
proposed fix

Attachment 243946 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5035683622158336

New failing tests:
fast/events/before-unload-adopt-subframe-to-outside.html

Comment 4 Build Bot 2015-01-04 16:30:33 PST

Created attachment 243949 [details]
Archive of layout-test-results from ews103 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 5 Build Bot 2015-01-04 16:35:54 PST

Comment on attachment 243946 [details]
proposed fix

Attachment 243946 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6465884109406208

New failing tests:
fast/events/before-unload-adopt-subframe-to-outside.html

Comment 6 Build Bot 2015-01-04 16:35:57 PST

Created attachment 243950 [details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 7 Alexey Proskuryakov 2015-01-05 23:22:17 PST

Created attachment 244036 [details]
proposed fix

Let's see what EWS thinks about this; it also fixes the test in my ASan build.

Comment 8 Alexey Proskuryakov 2015-01-06 00:04:41 PST

Comment on attachment 244036 [details]
proposed fix

EWS is green.

Comment 9 WebKit Commit Bot 2015-01-06 09:13:02 PST

Comment on attachment 244036 [details]
proposed fix

Clearing flags on attachment: 244036

Committed r177961: <http://trac.webkit.org/changeset/177961>

Comment 10 WebKit Commit Bot 2015-01-06 09:13:10 PST

All reviewed patches have been landed.  Closing bug.