Bug 140053

Summary: Web Inspector: purge PassRefPtr from Inspector code and use Ref for typed and untyped protocol objects
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dbates, esprehn+autocc, graouts, gyuyoung.kim, joepeck, jonowells, kangil.han, kling, mattbaker, mkwst, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 140002, 140187    
Bug Blocks:    
Attachments:
Description Flags
Patch
kling: review+, burg: commit-queue-
Patch for EWS
none
EWS round 2
none
EWS round 3
none
[PATCH] ObjC side fixes none

Brian Burg
Reported 2015-01-04 08:56:18 PST
Patch forthcoming.
Attachments
Patch (617.34 KB, patch)
2015-01-05 13:55 PST, Brian Burg
kling: review+
burg: commit-queue-
Patch for EWS (618.19 KB, patch)
2015-01-06 14:29 PST, Brian Burg
no flags
EWS round 2 (620.39 KB, patch)
2015-01-06 19:23 PST, Brian Burg
no flags
EWS round 3 (620.29 KB, patch)
2015-01-06 19:52 PST, Brian Burg
no flags
[PATCH] ObjC side fixes (6.06 KB, patch)
2015-01-07 14:34 PST, Joseph Pecoraro
no flags
Radar WebKit Bug Importer
Comment 1 2015-01-04 08:56:30 PST
Brian Burg
Comment 2 2015-01-05 13:55:02 PST
Created attachment 244000 [details] Patch Attached patch does not apply to ToT yet. Please review anyway, I will upload another patch until EWS runs cleanly.
Joseph Pecoraro
Comment 3 2015-01-05 15:33:36 PST
Did you r+ your own patch?
Brian Burg
Comment 4 2015-01-05 16:59:18 PST
Comment on attachment 244000 [details] Patch Doh, wrong button. Was running out the door. Thanks Joe.
Andreas Kling
Comment 5 2015-01-06 12:49:58 PST
Comment on attachment 244000 [details] Patch This looks very good to me. You should upload a new version for EWS once the dependencies have landed.
Brian Burg
Comment 6 2015-01-06 14:29:10 PST
Created attachment 244096 [details] Patch for EWS
WebKit Commit Bot
Comment 7 2015-01-06 14:30:22 PST
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`) This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 8 2015-01-06 14:30:46 PST
Attachment 244096 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:547: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:190: out_optionalValueFound is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/page/PageConsoleClient.h:59: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 3 in 122 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brian Burg
Comment 9 2015-01-06 19:23:16 PST
Created attachment 244125 [details] EWS round 2
Brian Burg
Comment 10 2015-01-06 19:52:40 PST
Created attachment 244128 [details] EWS round 3
WebKit Commit Bot
Comment 11 2015-01-06 21:01:20 PST
Attachment 244128 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:547: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:190: out_optionalValueFound is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/page/PageConsoleClient.h:59: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 3 in 124 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brian Burg
Comment 12 2015-01-07 09:33:18 PST
Committed r178039: <http://trac.webkit.org/changeset/178039> will be watching bots for next few hours in case any surprises.
WebKit Commit Bot
Comment 13 2015-01-07 11:28:47 PST
Re-opened since this is blocked by bug 140187
Joseph Pecoraro
Comment 14 2015-01-07 14:34:54 PST
Created attachment 244205 [details] [PATCH] ObjC side fixes These were the fixes to the generate necessary for the ObjC code changes. Brian, do these look good to you? If so, I can re-land your patch, with these changes, and with the Internal side of this (PassRefPtr -> RefPtr&& necessary changes).
Joseph Pecoraro
Comment 15 2015-01-07 15:29:28 PST
Alexey Proskuryakov
Comment 16 2015-01-14 15:00:11 PST
Comment on attachment 244128 [details] EWS round 3 View in context: https://bugs.webkit.org/attachment.cgi?id=244128&action=review > Source/WebCore/page/PageConsoleClient.cpp:156 > - ConsoleClient::printConsoleMessageWithArguments(MessageSource::ConsoleAPI, type, level, exec, arguments.release()); > + ConsoleClient::printConsoleMessageWithArguments(MessageSource::ConsoleAPI, type, level, exec, WTF::move(arguments)); This cannot work, we already moved out of arguments a few lines above.
Note You need to log in before you can comment on or make changes to this bug.