Bug 140002

Summary: Web Inspector: pass parameters to inspector agents by reference where possible
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 140053    
Attachments:
Description Flags
Patch kling: review+

Brian Burg
Reported 2014-12-29 19:03:52 PST
More cleanup. Push references another level down.
Attachments
Patch (95.07 KB, patch)
2015-01-05 13:42 PST, Brian Burg 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-12-29 19:04:20 PST
<rdar://problem/19358093>
Brian Burg
Comment 2 2015-01-05 13:42:55 PST
Created attachment 243999 [details] Patch
WebKit Commit Bot
Comment 3 2015-01-05 13:45:01 PST
Attachment 243999 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorResourceAgent.h:92: The parameter name "loader" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 4 2015-01-06 12:44:44 PST
Comment on attachment 243999 [details] Patch r=me
Brian Burg
Comment 5 2015-01-06 13:45:07 PST
Committed r177993: <http://trac.webkit.org/changeset/177993>
Note You need to log in before you can comment on or make changes to this bug.