Bug 140001

Summary: Remove DocumentLoader::requestURL().
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue, darin, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Sungmann Cho 2014-12-29 16:45:14 PST 
In DocumentLoader, url() is exactly the same as requestURL(), so we can remove one of them.
I think requestURL() is more descriptive than url().
Comment 1 Sungmann Cho 2014-12-29 16:56:52 PST 
Created attachment 243816 [details]
Patch
Comment 2 Sungmann Cho 2014-12-29 19:28:17 PST 
Hmm... but for blink, requestURL() was removed from DocumentLoader(http://goo.gl/i7Ak5E).
Which is better for us?
Comment 3 Alexey Proskuryakov 2015-01-06 23:03:36 PST 
Neither url() nor requestURL() are perfectly descriptive - when you say "request", is that the original request before all the client API calls, one modified by client, one after HSTS synthetic redirect, or one after actual HTTP redirects?
Comment 4 Sungmann Cho 2015-01-08 14:40:59 PST 
Agreed. On balance, what is the best name for it?
Comment 5 Sungmann Cho 2015-04-05 05:24:14 PDT 
Created attachment 250155 [details]
Patch
Comment 6 Darin Adler 2015-04-05 13:12:22 PDT 
Comment on attachment 250155 [details]
Patch

I slightly preferred requestURL despite Alexey’s remarks, but getting rid of the duplicate if good in any case.
Comment 7 Darin Adler 2015-04-05 13:12:35 PDT 
Sorry, “is good”.
Comment 8 WebKit Commit Bot 2015-04-05 16:32:25 PDT 
Comment on attachment 250155 [details]
Patch

Clearing flags on attachment: 250155

Committed r182367: <http://trac.webkit.org/changeset/182367>
Comment 9 WebKit Commit Bot 2015-04-05 16:32:29 PDT 
All reviewed patches have been landed.  Closing bug.