| Summary: | AX: [ATK] Whether to show the title attribute, if there is a label with the attribute for? | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andrzej Badowski <a.badowski> | ||||||||
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cfleizach, commit-queue, jdiggs, k.czech, mario, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
i think in this case, title attribute should go to AXHelp tag on Mac, since the labelled by overrides the title In the case of ATK, what the WebKit tests call AXTitle is the accessible name of the AtkObject. And the accessible name is in this case LABEL. So 'AXTitle: LABEL' is correct. The title attribute could be exposed as the accessible description of the AtkObject. (ATK perhaps should have "help" text, but it doesn't currently.) Created attachment 244334 [details]
proposed patch
Comment on attachment 244334 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=244334&action=review > LayoutTests/platform/efl/TestExpectations:2125 > +webkit.org/b/139150 fast/forms/form-hides-table.html [ Failure ] this seems like an unnecessary change Comment on attachment 244334 [details] proposed patch Rejecting attachment 244334 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 244334, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t 2120. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/efl/TestExpectations.rej patching file LayoutTests/platform/efl/accessibility/radio-button-title-label-expected.txt patching file LayoutTests/platform/gtk/TestExpectations patching file LayoutTests/platform/gtk/accessibility/radio-button-title-label-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Fleizach']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6091515969404928 Created attachment 244440 [details]
proposed patch 2
Comment on attachment 244440 [details] proposed patch 2 Rejecting attachment 244440 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 244440, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/4633496442109952 Created attachment 244441 [details]
proposed patch 3
Comment on attachment 244441 [details] proposed patch 3 Clearing flags on attachment: 244441 Committed r178255: <http://trac.webkit.org/changeset/178255> All reviewed patches have been landed. Closing bug. |
I have a problem. Is it necessary to show the title attribute of a radio button (or another element), if there is a label tag attribute for referring to the first element? I do not mean to show it directly, but through the text associated with the label. Here is an example taken from the test accessibility/radio-button-title-label.html for Mac: <input type="radio" name="r1" id="r1" title="TITLE">Test<br> <label id="label1" for="r1">LABEL</label> Expected result for r1.title (r1 - accessibleElementById("r1")) is: 'AXTitle: ' (mac). If this test is made for efl or gtk, it returns 'AXTitle: LABEL'. If this is correct, it would suffice small modification of this test for the ATK case. If not, it is probably necessary amendment in the core area.