Bug 139959 – Handle more types in the UserData encode/decode functions

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Handle more types in the UserData encode/decode functions

[Anders Carlsson]

Created attachment 243764 [details]
Patch

Comment on attachment 243764 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243764&action=review

> Source/WebKit2/Shared/UserData.cpp:414
> +        return true;

Why not break; like elsewhere?

> Source/WebKit2/Shared/UserData.cpp:476
> +

No need for this empty line.

> Source/WebKit2/Shared/UserData.cpp:514
> +        if (children && children->type() != API::Object::Type::Array)
> +            return false;

Why do you type-check children here but not elementClassNames and not any of the API objects decoded in RenderLayer?

[Anders Carlsson]

(In reply to comment #2)

> > Source/WebKit2/Shared/UserData.cpp:514
> > +        if (children && children->type() != API::Object::Type::Array)
> > +            return false;
> 
> Why do you type-check children here but not elementClassNames and not any of
> the API objects decoded in RenderLayer?

This code is just copied from the legacy decoder. I guess you'll have to ask the author of that patch...

[Anders Carlsson]

Committed r177750: <http://trac.webkit.org/changeset/177750>