Bug 139950

Summary:

REGRESSION (r177027): iOS builds use the wrong toolchain

Product:

WebKit

Reporter:

mitz

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, ddkilzer, dino, kondapallykalyan, mrowe, roger_fong

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Only define TOOLCHAINS when building for OS X	ddkilzer: review+

mitz

Reported 2014-12-25 22:32:06 PST

After <http://trac.webkit.org/r177027>, when building for iOS, TOOLCHAINS ends up with the empty value, so the default toolchain is being used instead of the toolchain specified by the iOS SDK.

Attachments
Only define TOOLCHAINS when building for OS X (13.99 KB, patch) 2014-12-25 23:06 PST, mitz	ddkilzer: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2014-12-25 22:59:19 PST

<rdar://problem/19348208>

mitz

Comment 2 2014-12-25 23:06:17 PST

Created attachment 243757 [details] Only define TOOLCHAINS when building for OS X

WebKit Commit Bot

Comment 3 2014-12-25 23:07:41 PST

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

David Kilzer (:ddkilzer)

Comment 4 2014-12-26 03:25:20 PST

Comment on attachment 243757 [details] Only define TOOLCHAINS when building for OS X r=me

mitz

Comment 5 2014-12-26 07:45:59 PST

Fixed in <http://trac.webkit.org/r177746>.

Note You need to log in before you can comment on or make changes to this bug.