Bug 139936

Summary:

ANGLE extern symbols are not hidden by default, but should be

Product:

WebKit

Reporter:

mitz

Component:

WebGL

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, dino, kondapallykalyan, mrowe, roger_fong, sam, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

136172

Attachments:

Description	Flags
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES	mrowe: review+

Description mitz 2014-12-24 14:46:35 PST

Once WebCore stops using an exports file, the default visibility of ANGLE symbols will carry over to WebCore. WebCore shouldn’t export any ANGLE symbols, so ANGLE should build with -fvisibility=hidden.

Comment 1 mitz 2014-12-24 14:50:28 PST

Created attachment 243729 [details]
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES

Comment 2 WebKit Commit Bot 2014-12-24 14:53:21 PST

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

Comment 3 mitz 2014-12-24 15:10:33 PST

Fixed in <http://trac.webkit.org/r177724>.