Bug 139936

Summary: ANGLE extern symbols are not hidden by default, but should be
Product: WebKit Reporter: mitz
Component: WebGLAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, dino, kondapallykalyan, mrowe, roger_fong, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136172    
Attachments:
Description Flags
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES mrowe: review+

mitz
Reported 2014-12-24 14:46:35 PST
Once WebCore stops using an exports file, the default visibility of ANGLE symbols will carry over to WebCore. WebCore shouldn’t export any ANGLE symbols, so ANGLE should build with -fvisibility=hidden.
Attachments
Change GCC_SYMBOLS_PRIVATE_EXTERN to YES (1.21 KB, patch)
2014-12-24 14:50 PST, mitz 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-12-24 14:50:28 PST
Created attachment 243729 [details] Change GCC_SYMBOLS_PRIVATE_EXTERN to YES
WebKit Commit Bot
Comment 2 2014-12-24 14:53:21 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
mitz
Comment 3 2014-12-24 15:10:33 PST
Fixed in <http://trac.webkit.org/r177724>.
Note You need to log in before you can comment on or make changes to this bug.