Bug 139888

Summary:

Saturated arithmetics: Incorrect float/double clamping.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2014-12-22 17:25:28 PST

#if ENABLE(SATURATED_LAYOUT_ARITHMETIC)
-        m_value = clampTo<float>(value * kFixedPointDenominator, static_cast<float>(INT_MIN), static_cast<float>(INT_MAX));
+        m_value = clampToInteger(value * kFixedPointDenominator);
 #else

Comment 1 zalan 2014-12-22 17:28:02 PST

rdar://problem/19330885

Comment 2 zalan 2014-12-22 17:29:55 PST

Created attachment 243653 [details]
Patch

Comment 3 zalan 2014-12-31 22:56:07 PST

Created attachment 243858 [details]
Patch

Comment 4 WebKit Commit Bot 2015-01-01 00:32:29 PST

Comment on attachment 243858 [details]
Patch

Clearing flags on attachment: 243858

Committed r177845: <http://trac.webkit.org/changeset/177845>

Comment 5 WebKit Commit Bot 2015-01-01 00:32:33 PST

All reviewed patches have been landed.  Closing bug.