Bug 139883

Summary:

[Mac] Engineering builds of WebCore on OS X 10.8 and 10.9 shouldn't build with -gline-tables-only

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

WebCore Misc.

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Mark Rowe (bdash)

Reported 2014-12-22 16:33:51 PST

The logic I added in r177254 was incorrect with regards to the precedence of conditional build settings vs unconditional ones. This has resulted in engineering builds of WebCore on OS X 10.8 and 10.9 being incorrectly built with -gline-tables-only. <rdar://problem/19297261>

Attachments
Patch (1.55 KB, patch) 2014-12-22 16:37 PST, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2014-12-22 16:37:37 PST

Created attachment 243647 [details] Patch

Alexey Proskuryakov

Comment 2 2014-12-22 17:31:57 PST

Comment on attachment 243647 [details] Patch rs=me

WebKit Commit Bot

Comment 3 2014-12-22 18:24:28 PST

Comment on attachment 243647 [details] Patch Clearing flags on attachment: 243647 Committed r177674: <http://trac.webkit.org/changeset/177674>

WebKit Commit Bot

Comment 4 2014-12-22 18:24:31 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.