Bug 139864 – Generic font code should not know about SVG font missing glyph

• Component: Text
• Status: RESOLVED FIXED

[Antti Koivisto]

It is an SVG font concept and should be handled in SVG code.

[Antti Koivisto]

Created attachment 243625 [details]
patch

[Myles C. Maxfield]

Comment on attachment 243625 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243625&action=review

r=me

> Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:295
> +    const SimpleFontData* primaryFontData = font.primaryFont();

This logic seems completely busted (of always pulling out the primary font). Luckily SVG fonts as a whole are going away...

[Andreas Kling]

Comment on attachment 243625 [details]
patch

I trust Myles on this. r+

[Myles C. Maxfield]

Seems like this means that we'll never show the SVG font's missing-glyph. I think that's okay, but other people on the team might have opinions.

[Antti Koivisto]

(In reply to comment #4)
> Seems like this means that we'll never show the SVG font's missing-glyph. I
> think that's okay, but other people on the team might have opinions.

There shouldn't be any behavior change, the missing glyphs work as before (and there are tests). They are just resolved bit differently.

[Antti Koivisto]

https://trac.webkit.org/r177637

[Brent Fulgham]

This breaks the Windows build:

         UniscribeController.cpp
     1>..\platform\graphics\win\SimpleFontDataCGWin.cpp(91): error C2027: use of undefined type 'WebCore::GlyphPageTreeNode'
                 c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\platform\graphics\GlyphPage.h(43) : see declaration of 'WebCore::GlyphPageTreeNode'
     1>..\platform\graphics\win\SimpleFontDataCGWin.cpp(91): error C2227: left of '->page' must point to class/struct/union/generic type
                 type is 'unknown-type'
     1>..\platform\graphics\win\SimpleFontDataCGWin.cpp(91): error C3861: 'getRootChild': identifier not found
         ScrollbarThemeMock.cpp
         FormData.cpp

I think we're just missing a #include in the win/SimpleFontDataCGWin.cpp. I'm testing this now and will check in a fix shortly if it works.

[Brent Fulgham]

Build fix (Windows);

https://trac.webkit.org/r177644.

[Antti Koivisto]

Build fix was https://trac.webkit.org/r177642

[Csaba Osztrogonác]

(In reply to comment #6)
> https://trac.webkit.org/r177637

It made 3 tests crash on EFL and GTK, here is the new bug report:
https://bugs.webkit.org/show_bug.cgi?id=139905