Bug 139838

Summary: Web Inspector: Inspector does not reopen correctly after Inspector Process crashes
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, graouts, joepeck, jonowells, mattbaker, mkwst, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-12-19 15:34:33 PST
* SUMMARY
Inspector does not reopen correctly after Inspector Process crashes. There are two issues:

    (1) Debug Build hits an ASSERT:
    (2) Ignoring the ASSERT, the Inspector window opens blank (when forced to show).

Closing and reopening the inspector, it then works.

* STEPS TO REPRODUCE
1. Open inspector
2. shell> kill -9 <pid-of-inspector-process>
3. Reopen inspector
  => ASSERT || broken inspector

* NOTES
ASSERTION FAILED: !WebInspectorProxy::isInspectorPage(*this)
Source/WebKit2/UIProcess/WebPageProxy.cpp(717) : bool WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle(const WebCore::URL &, SandboxExtension::Handle &)
1   0x10457ed00 WTFCrashWithSecurityImplication
2   0x106b46584 WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle(WebCore::URL const&, WebKit::SandboxExtension::Handle&)
3   0x106b466c2 WebKit::WebPageProxy::loadRequest(WebCore::ResourceRequest const&, API::Object*)
4   0x106a7e530 WebKit::WebInspectorProxy::createInspectorPage(IPC::Attachment, bool, bool)
5   0x106a9319a void IPC::callMemberFunctionImpl
...
Comment 1 Radar WebKit Bug Importer 2014-12-19 15:34:44 PST
<rdar://problem/19314136>
Comment 2 Joseph Pecoraro 2014-12-19 15:42:14 PST
Created attachment 243583 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2014-12-19 15:42:43 PST
Better Radar: <rdar://problem/19124870>
Comment 4 WebKit Commit Bot 2014-12-19 16:58:00 PST
Comment on attachment 243583 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 243583

Committed r177610: <http://trac.webkit.org/changeset/177610>
Comment 5 WebKit Commit Bot 2014-12-19 16:58:04 PST
All reviewed patches have been landed.  Closing bug.