Bug 139830

Summary: [WinCairo] Crash after failing to create GL context in accelerated compositing mode.
Product: WebKit Reporter: peavo
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description peavo 2014-12-19 12:54:13 PST 
There is missing a null pointer check.
Comment 1 peavo 2014-12-19 12:57:31 PST 
Created attachment 243569 [details]
Patch
Comment 2 Alex Christensen 2014-12-19 13:25:34 PST 
Comment on attachment 243569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243569&action=review

> Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:99
> +    m_context = GLContext::createContextForWindow(m_window, GLContext::sharingContext());

What if we already have a context?  Shouldn't this also be in an if (!m_context)?
Comment 3 peavo 2014-12-19 13:30:20 PST 
Created attachment 243572 [details]
Patch
Comment 4 peavo 2014-12-19 13:31:02 PST 
(In reply to comment #2)
> Comment on attachment 243569 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243569&action=review
> 
> > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:99
> > +    m_context = GLContext::createContextForWindow(m_window, GLContext::sharingContext());
> 
> What if we already have a context?  Shouldn't this also be in an if
> (!m_context)?

Thanks for reviewing :) Updated patch.
Comment 5 WebKit Commit Bot 2014-12-19 14:06:24 PST 
Comment on attachment 243572 [details]
Patch

Clearing flags on attachment: 243572

Committed r177595: <http://trac.webkit.org/changeset/177595>
Comment 6 WebKit Commit Bot 2014-12-19 14:06:29 PST 
All reviewed patches have been landed.  Closing bug.