Bug 139821

Summary: REGRESSION(r177574): "Broke Production builds by installing libWebCoreTestSupport.dylib in the wrong directory" (Requested by ddkilzer on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 139463    
Attachments:
Description Flags
ROLLOUT of r177574 none

WebKit Commit Bot
Reported 2014-12-19 11:00:49 PST
http://trac.webkit.org/changeset/177574 broke the build: "Broke Production builds by installing libWebCoreTestSupport.dylib in the wrong directory" (Requested by ddkilzer on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r177574 (95.00 KB, patch)
2014-12-19 11:01 PST, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2014-12-19 11:01:23 PST
Created attachment 243557 [details] ROLLOUT of r177574 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Commit Bot
Comment 2 2014-12-19 11:07:51 PST
Comment on attachment 243557 [details] ROLLOUT of r177574 Clearing flags on attachment: 243557 Committed r177580: <http://trac.webkit.org/changeset/177580>
WebKit Commit Bot
Comment 3 2014-12-19 11:07:54 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 4 2014-12-19 11:09:40 PST
The DumpRenderTree-can't-link-to-libWebCoreTestSupport.dylib issue is due to the wrong directory being used: -SymLink /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Symbols/BuiltProducts/libWebCoreTestSupport.dylib /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Root/usr/local/lib/libWebCoreTestSupport.dylib +SymLink /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Symbols/BuiltProducts/libWebCoreTestSupport.dylib /Volumes/Data/slave/yosemite-production-archive/build/build-Production/WebCore.roots/BuildRecords/WebCore_install/Root/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/libWebCoreTestSupport.dylib So it looks like some value in WebCoreTestSupport.xcconfig wasn't being overridden properly, probably INSTALL_PATH.
David Kilzer (:ddkilzer)
Comment 5 2014-12-19 11:18:25 PST
I also noticed that the order file wasn't being set for JavaScriptCore and WebCore builds. This leads me to believe that doing things like this just lead to unexpected behavior and sadness (namely the variables are never set when building with xcodebuild, but look fine with using the Xcode UI): +SECTORDER_FLAGS[sdk=iphoneos*][config=Production] = -Wl,-order_file,$(SDKROOT)/AppleInternal/OrderFiles/JavaScriptCore.order; +SECTORDER_FLAGS[sdk=macosx*][config=Production] = -Wl,-order_file,JavaScriptCore.order;
David Kilzer (:ddkilzer)
Comment 6 2014-12-20 11:06:22 PST
Re-landed with [config=] selectors removed: Committed r177621: <http://trac.webkit.org/changeset/177621> See Bug 139463.
Note You need to log in before you can comment on or make changes to this bug.