Bug 139805

Summary:

Fix build break on EFL and GTK since r177523

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

139790

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Description Gyuyoung Kim 2014-12-18 19:47:28 PST

r177523 made build break on EFL and GTK ports.

Comment 1 Gyuyoung Kim 2014-12-18 19:48:14 PST

Created attachment 243537 [details]
Patch

Comment 2 Anders Carlsson 2014-12-18 21:35:55 PST

Comment on attachment 243537 [details]
Patch

This isn't the right fix - the right fix is t make sure that the definition in wtf/StdLibExtras.h is used on versions less than 4.9.0!

Comment 3 Gyuyoung Kim 2014-12-18 22:32:04 PST

Created attachment 243543 [details]
Patch

Comment 4 Gyuyoung Kim 2014-12-18 22:33:42 PST

(In reply to comment #2)
> Comment on attachment 243537 [details]
> Patch
> 
> This isn't the right fix - the right fix is t make sure that the definition
> in wtf/StdLibExtras.h is used on versions less than 4.9.0!

Anders, Ref.h seems to need to include <wtf/StdLibExtras.h> explicitly. EFL and GTK port don't recognize std::exchange() defined in wtf/StdLibExtras.h.

Comment 5 Csaba Osztrogonác 2014-12-18 23:12:24 PST

Comment on attachment 243543 [details]
Patch

rs=me

Comment 6 WebKit Commit Bot 2014-12-18 23:45:29 PST

Comment on attachment 243543 [details]
Patch

Clearing flags on attachment: 243543

Committed r177568: <http://trac.webkit.org/changeset/177568>

Comment 7 WebKit Commit Bot 2014-12-18 23:45:33 PST

All reviewed patches have been landed.  Closing bug.

Comment 8 Anders Carlsson 2014-12-19 08:55:52 PST

Ah, sorry about that. Thanks for fixing!