Bug 139801

Summary:

[Win] Endless compiler warnings created by DFGEdge.h

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, mark.lam, msaboff

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	none

Description Brent Fulgham 2014-12-18 16:49:19 PST

Recent changes have introduced tons of compiler warnings:

10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCSEPhase.cpp)
10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGClobberize.cpp)
10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGClobberSet.cpp)
10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCommon.cpp)
10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCommonData.cpp)
10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCriticalEdgeBreakingPhase.cpp)
10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGConstantFoldingPhase.cpp)
10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGDCEPhase.cpp)

Comment 1 Brent Fulgham 2014-12-18 16:50:14 PST

Also:

10>..\runtime\BasicBlockLocation.cpp(55): warning C4245: 'initializing' : conversion from 'int' to 'unsigned int', signed/unsigned mismatch

Comment 2 Brent Fulgham 2014-12-18 16:50:41 PST

Note: Many of these warnings are being generated by 32-bit builds.

Comment 3 Mark Lam 2014-12-19 11:04:07 PST

Created attachment 243558 [details]
the patch.

Comment 4 Brent Fulgham 2014-12-19 11:06:02 PST

Comment on attachment 243558 [details]
the patch.

Looks good to me! r=me.

Comment 5 WebKit Commit Bot 2014-12-19 11:26:41 PST

Comment on attachment 243558 [details]
the patch.

Clearing flags on attachment: 243558

Committed r177582: <http://trac.webkit.org/changeset/177582>

Comment 6 WebKit Commit Bot 2014-12-19 11:26:44 PST

All reviewed patches have been landed.  Closing bug.