Bug 139783

Summary: Web Inspector: ASSERT seen closing/opening multiple inspectors
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2014-12-18 11:21:28 PST
I occasionally see this assert in Inspector code when opening/closing multiple inspectors repeatedly in Debug builds.

    Deprecated::ScriptValue InjectedScript::findObjectById(const String& objectId) const

We can safely avoid calling findObjectById if we have an empty InjectedScript.
Comment 1 Radar WebKit Bug Importer 2014-12-18 11:22:06 PST
Comment 2 Joseph Pecoraro 2014-12-18 11:22:19 PST
Created attachment 243504 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-12-18 12:45:24 PST
Comment on attachment 243504 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 243504

Committed r177518: <http://trac.webkit.org/changeset/177518>
Comment 4 WebKit Commit Bot 2014-12-18 12:45:28 PST
All reviewed patches have been landed.  Closing bug.