| Summary: | Fix the GTK build after r177452 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, cgarcia, clopez, commit-queue, kling, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 139735 | ||||||
| Attachments: |
|
||||||
|
Description
Csaba Osztrogonác
2014-12-17 15:36:21 PST
Created attachment 243465 [details]
Patch
Attachment 243465 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
I don't know what is PluginDatabase, if GTK really needs it or not, ... It is only a speculative fix, which made the build happy. Feel free to reuse this patch and fix it properly. Maybe removing code from FrameLoader.cpp is absolutely incorrect, at least !COCOA&&!EFL&&!GTK port ( == WIN ? ). Thanks for the analysis! Turns out that FrameLoader::defaultObjectContentType is only used on Windows, so I'm going to move that code there. I got rid of the function in https://trac.webkit.org/r177482 cmake fix landed in https://trac.webkit.org/changeset/177488 |