Bug 139752

Summary: Fix the GTK build after r177452
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, clopez, commit-queue, kling, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 139735    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-12-17 15:36:21 PST
Fix the GTK build after r177452
Attachments
Patch (3.89 KB, patch)
2014-12-17 15:36 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-12-17 15:36:38 PST
Created attachment 243465 [details] Patch
WebKit Commit Bot
Comment 2 2014-12-17 15:38:29 PST
Attachment 243465 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 3 2014-12-17 15:40:47 PST
I don't know what is PluginDatabase, if GTK really needs it or not, ... It is only a speculative fix, which made the build happy. Feel free to reuse this patch and fix it properly. Maybe removing code from FrameLoader.cpp is absolutely incorrect, at least !COCOA&&!EFL&&!GTK port ( == WIN ? ).
Anders Carlsson
Comment 4 2014-12-17 16:59:22 PST
Thanks for the analysis! Turns out that FrameLoader::defaultObjectContentType is only used on Windows, so I'm going to move that code there.
Anders Carlsson
Comment 5 2014-12-17 17:56:58 PST
I got rid of the function in https://trac.webkit.org/r177482
Csaba Osztrogonác
Comment 6 2014-12-17 23:19:22 PST
cmake fix landed in https://trac.webkit.org/changeset/177488
Note You need to log in before you can comment on or make changes to this bug.