Summary: | Web Inspector: [Mac] Occasional Crashes Closing Inspector | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, commit-queue, enrica, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-12-17 12:12:25 PST
Created attachment 243451 [details]
[PATCH] Proposed Fix
Comment on attachment 243451 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=243451&action=review > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:296 > + WebPageProxy* inspectorPage = toImpl(m_inspectorView.get().pageRef); > + inspectorPage->close(); WKView dealloc calls close(), but that assumes we hold the last ref here. Comment on attachment 243451 [details] [PATCH] Proposed Fix Clearing flags on attachment: 243451 Committed r177459: <http://trac.webkit.org/changeset/177459> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > Comment on attachment 243451 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243451&action=review > > > Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:296 > > + WebPageProxy* inspectorPage = toImpl(m_inspectorView.get().pageRef); > > + inspectorPage->close(); > > WKView dealloc calls close(), but that assumes we hold the last ref here. Correct, we were not holding the lat ref, because the WKWebInspectorWKView was being retained by a dispatch_async block. =( |