Bug 139735

Summary: Get rid of PluginPackageNone.cpp
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 139752    
Bug Blocks:    
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2014-12-17 11:02:16 PST
Get rid of PluginPackageNone.cpp
Attachments
Patch (4.81 KB, patch)
2014-12-17 11:02 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-12-17 11:02:39 PST
Created attachment 243444 [details] Patch
Anders Carlsson
Comment 2 2014-12-17 12:09:46 PST
Committed r177452: <http://trac.webkit.org/changeset/177452>
Anders Carlsson
Comment 4 2014-12-17 13:22:26 PST
(In reply to comment #3) > (In reply to comment #2) > > Committed r177452: <http://trac.webkit.org/changeset/177452> > > This has broken the GTK build: > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at all.
Csaba Osztrogonác
Comment 5 2014-12-17 15:32:29 PST
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Committed r177452: <http://trac.webkit.org/changeset/177452> > > > > This has broken the GTK build: > > https://build.webkit.org/builders/GTK%20Linux%2064- > > bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio > > OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at > all. It seems PluginDatabase is used by GTK in FrameLoader.cpp in !PLATFORM(COCOA) && !PLATFORM(EFL) blocks.
Note You need to log in before you can comment on or make changes to this bug.