Bug 139735

Summary:

Get rid of PluginPackageNone.cpp

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, clopez, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

139752

Bug Blocks:

Attachments:

Description	Flags
Patch	kling: review+

Description Anders Carlsson 2014-12-17 11:02:16 PST

Get rid of PluginPackageNone.cpp

Comment 1 Anders Carlsson 2014-12-17 11:02:39 PST

Created attachment 243444 [details]
Patch

Comment 2 Anders Carlsson 2014-12-17 12:09:46 PST

Committed r177452: <http://trac.webkit.org/changeset/177452>

Comment 3 Carlos Alberto Lopez Perez 2014-12-17 13:20:50 PST

(In reply to comment #2)
> Committed r177452: <http://trac.webkit.org/changeset/177452>

This has broken the GTK build: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio

Comment 4 Anders Carlsson 2014-12-17 13:22:26 PST

(In reply to comment #3)
> (In reply to comment #2)
> > Committed r177452: <http://trac.webkit.org/changeset/177452>
> 
> This has broken the GTK build:
> https://build.webkit.org/builders/GTK%20Linux%2064-
> bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio

OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at all.

Comment 5 Csaba Osztrogonác 2014-12-17 15:32:29 PST

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Committed r177452: <http://trac.webkit.org/changeset/177452>
> > 
> > This has broken the GTK build:
> > https://build.webkit.org/builders/GTK%20Linux%2064-
> > bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio
> 
> OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at
> all.

It seems PluginDatabase is used by GTK in FrameLoader.cpp in !PLATFORM(COCOA) && !PLATFORM(EFL) blocks.