Bug 13972

Summary:

Quicktime does not respect CSS clip and overflow

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Plug-ins

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

simon.fraser

Priority:

Keywords:

InRadar

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch that fixes Quicktime.	mrowe: review-
Override the WebKit plugin view's visibleRect method to respect clip and overflow	none

Dave Hyatt

Reported 2007-06-01 15:45:47 PDT

Flash and Netscape plugins respect it now, but Quicktime (a Webkit plugin) does not. It relies on NSView's visibleRect method to know what to clip. This bug tracks reworking all plugins so that visibleRect is the way to clip.

Attachments
Patch that fixes Quicktime. (14.07 KB, patch) 2007-06-01 15:46 PDT, Dave Hyatt	mrowe: review-	Details Formatted Diff Diff
Override the WebKit plugin view's visibleRect method to respect clip and overflow (23.06 KB, patch) 2007-06-17 14:19 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2007-06-01 15:46:19 PDT

Created attachment 14835 [details] Patch that fixes Quicktime.

Dave Hyatt

Comment 2 2007-06-06 00:16:45 PDT

Fixed.

Dave Hyatt

Comment 3 2007-06-16 23:03:29 PDT

Backed out this fix since it regressed mail.

Mark Rowe (bdash)

Comment 4 2007-06-17 14:19:17 PDT

Created attachment 15093 [details] Override the WebKit plugin view's visibleRect method to respect clip and overflow This patch fixes QuickTime clipping without breaking Mail. It does this in a somewhat hackish way: it swizzles the plugin view's visibleRect implementation with one that understands WebCore clipping. This approach would be much less likely to interfere with applications such as Mail that use custom WebKit plugins to provide functionality. The tradeoff is that the approach feels a bit nasty. It's worth noting that the MethodSwizzle.* files are under an MIT-style license. I'm not clear whether that's acceptable for inclusion in WebKit. It also lacks support for the new Obj-C runtime, I can implementat that before this is reviewed if the general approach is deemed nasty-but-acceptable.

Mark Rowe (bdash)

Comment 5 2007-06-17 14:34:47 PDT

Comment on attachment 14835 [details] Patch that fixes Quicktime. Clearing review as most of this patch was rolled out.

David Harrison

Comment 6 2008-11-26 12:52:25 PST

rdar://problem/4338918

Simon Fraser (smfr)

Comment 7 2010-10-20 16:28:38 PDT

No longer an issue with composited plugins.

Note You need to log in before you can comment on or make changes to this bug.