Bug 139719

Summary:

Fix lambda and std::function formatting

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Anders Carlsson

Reported 2014-12-16 18:50:18 PST

Fix lambda and std::function formatting

Attachments
Patch (80.13 KB, patch) 2014-12-16 18:50 PST, Anders Carlsson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2014-12-16 18:50:35 PST

Created attachment 243421 [details] Patch

WebKit Commit Bot

Comment 2 2014-12-16 18:52:03 PST

Attachment 243421 [details] did not pass style-queue: ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:190: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:214: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:285: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:290: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:295: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:300: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:305: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:310: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:349: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:414: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:442: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:492: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:526: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:560: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:583: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:606: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:629: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:650: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:671: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:692: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:64: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:66: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:75: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/WebContextMenuItemData.h:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/WebContextMenuItemData.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/OriginData/WebOriginDataManagerSupplement.h:40: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/OriginData/WebOriginDataManagerSupplement.h:41: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/OriginData/WebOriginDataManagerSupplement.h:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/OriginData/WebOriginDataManagerSupplement.h:43: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:84: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:311: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.h:290: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.h:291: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.h:292: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.h:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/WebContextMenuItemData.cpp:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.cpp:1260: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.cpp:1276: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.cpp:1293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/WebProcess.cpp:1310: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:283: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:295: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:308: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:321: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncTask.h:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/AsyncTask.h:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:84: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:85: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:86: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:87: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:92: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:93: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:94: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:101: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:136: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:190: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:244: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:276: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:308: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:312: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:342: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:371: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:400: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:419: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:510: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:539: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:568: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:597: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:626: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:655: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:672: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:689: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebOriginDataManagerProxy.cpp:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebOriginDataManagerProxy.cpp:119: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebOriginDataManagerProxy.cpp:128: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebContext.cpp:198: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 109 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2014-12-16 18:54:18 PST

Committed r177426: <http://trac.webkit.org/changeset/177426>

Darin Adler

Comment 4 2014-12-16 23:22:39 PST

I don’t know the suggested format. I would like to see it somewhere, maybe in coding style guideline document. I hate that check-webkit-style is complaining about all of this!

Note You need to log in before you can comment on or make changes to this bug.