Summary: | Subpixel rendering: Animating HTML elements leaves trails when embedded to a subpxiel positioned iframe. | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
zalan
2014-12-16 11:56:41 PST
Created attachment 243374 [details]
Test reduction.
Created attachment 243380 [details]
Patch
Comment on attachment 243380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243380&action=review > Source/WebCore/rendering/RenderBox.cpp:2191 > + // FIXME: This is needed as long as RenderWidget snaps to integral size/position. > + if (isRenderReplaced() && isWidget()) > + locationOffset = toIntSize(flooredIntPoint(locationOffset)); It would be good to put a comment in RenderWidget referencing this snapping. Are there any other computeRectForRepaint impls that needs this change? > LayoutTests/ChangeLog:16 > + * platform/mac/fast/images/repaint-subrect-grid-expected.txt: repaint rect tracking change. > + * platform/mac/fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move-expected.txt: Added. repaint rect tracking change. > + * platform/mac/fast/repaint/hidpi-device-pixel-based-repaint-rect-tracking-expected.txt: Added. repaint rect tracking change. > + * platform/mac/fast/repaint/hidpi-transform-on-subpixel-repaintrect-expected.txt: Added. repaint rect tracking change. These should go in the cross-platform dir. Comment on attachment 243380 [details] Patch Attachment 243380 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4698876044902400 New failing tests: fast/repaint/hidpi-content-inside-iframe-leaves-trails.html fast/repaint/hidpi-transform-on-subpixel-repaintrect.html fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html fast/images/repaint-subrect-grid.html fast/repaint/hidpi-device-pixel-based-repaint-rect-tracking.html Created attachment 243385 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 243389 [details]
Patch
Repaint rect tracking behavior change is moved here: bug 139703 Comment on attachment 243389 [details] Patch Attachment 243389 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4530429575036928 New failing tests: fast/repaint/hidpi-content-inside-iframe-leaves-trails.html Created attachment 243394 [details]
Archive of layout-test-results from ews105 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 243399 [details]
Patch
Comment on attachment 243399 [details] Patch Clearing flags on attachment: 243399 Committed r177412: <http://trac.webkit.org/changeset/177412> All reviewed patches have been landed. Closing bug. |