Summary: | [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, ddkilzer, simon.fraser | ||||||||
Priority: | P2 | Keywords: | InRadar, Regression | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | iOS 8.1 | ||||||||||
Attachments: |
|
Description
Daniel Bates
2014-12-16 11:07:50 PST
Created attachment 243368 [details]
Patch
Comment on attachment 243368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243368&action=review > Tools/ChangeLog:15 > + Following <http://trac.webkit.org/changeset/174642>, when we receive a -didFinishLoadForFrame > + delegate callback DumpRenderTree.app allows the WebThread to run before dumping the output of > + a test. And the WebThread may load a new page during this time, which will ultimately lead to > + dumping the test result again. Therefore, we should only dump the test result if neither a new > + load began nor testRunner.waitUntilDone() was called after allowing the WebThread to run. I'm concerned that this adds more unpredictability and flakiness. We first ask to dump results, then refuse to based on some out-of-band state, and without any guarantee that we will ultimately dump the results. If we already decided that the test is complete, we should not make racy second guesses later. Comment on attachment 243368 [details]
Patch
This fix is incorrect.
Created attachment 244736 [details]
Patch
Created attachment 244737 [details]
Patch
Comment on attachment 244737 [details] Patch Clearing flags on attachment: 244737 Committed r178570: <http://trac.webkit.org/changeset/178570> All reviewed patches have been landed. Closing bug. |