Bug 139668

Summary: Move WebCore/platform/image-decoders to std::unique_ptr<>
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch kling: review+

Description Gyuyoung Kim 2014-12-15 20:17:23 PST 
SSIA
Comment 1 Gyuyoung Kim 2014-12-15 20:19:03 PST 
Created attachment 243339 [details]
Patch
Comment 2 Andreas Kling 2014-12-16 18:07:45 PST 
Comment on attachment 243339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243339&action=review

r=me

> Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:144
> +        typedef Vector<std::unique_ptr<BMPImageReader> > BMPReaders;

Templates can end in ">>" nowadays, no need for "> >"

> Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:146
> +        typedef Vector<std::unique_ptr<PNGImageDecoder> > PNGDecoders;

Ditto.
Comment 3 Gyuyoung Kim 2014-12-16 18:11:19 PST 
Committed r177423: <http://trac.webkit.org/changeset/177423>
Comment 4 Gyuyoung Kim 2014-12-16 18:24:23 PST 
(In reply to comment #2)
> Comment on attachment 243339 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243339&action=review
> 
> r=me
> 
> > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:144
> > +        typedef Vector<std::unique_ptr<BMPImageReader> > BMPReaders;
> 
> Templates can end in ">>" nowadays, no need for "> >"
> 
> > Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.h:146
> > +        typedef Vector<std::unique_ptr<PNGImageDecoder> > PNGDecoders;
> 
> Ditto.

Fixed all, Thanks.