Bug 139661 – Make lookup an immediate action instead of an action menu item

• Component: WebKit2
• Status: RESOLVED FIXED

[Beth Dakin]

Make lookup an immediate action instead of an action menu item

rdar://problem/19198414

[Beth Dakin]

Created attachment 243329 [details]
Patch

[WebKit Commit Bot]

Attachment 243329 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:317:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:998:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:998:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.h:998:  The parameter name "presentationTransition" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:519:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:519:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 6 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 243329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243329&action=review

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:518
> +        // Run the animations serially because attaching another subwindow breaks the bounce animation.
> +        // We could consider making the bounce NSAnimationNonblockingThreaded instead, which seems
> +        // to work, but need to consider all of the implications.

Please remove this comment.

> Source/WebKit/mac/WebView/WebImmediateActionController.mm:350
> +    DictionaryPopupInfo dictionaryPopupInfo = dictionaryPopupInfoForRange(frame, *dictionaryRange, options, TextIndicatorPresentationTransition::BounceAndCrossfade);

Plz just bounce.

> Source/WebKit/mac/WebView/WebView.mm:8662
> +- (id)_animationControllerForDictionaryLookupPopupInfo:(const DictionaryPopupInfo&)dictionaryPopupInfo

It would be nice if someday this could share more code with the function above.

[Beth Dakin]

Thanks Tim! http://trac.webkit.org/changeset/177323