Bug 139630

Summary:

PutLocalSinkingPhase has an invalid assertion about incoming values, because both liveness and deferral analyses are conservative

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, fpizlo, ggaren, mark.lam, mhahnenb, mmirman, msaboff, oliver, saam, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	none
the patch	none

Description Filip Pizlo 2014-12-14 17:24:36 PST

...

Comment 1 Filip Pizlo 2014-12-14 17:28:48 PST

Created attachment 243274 [details]
the patch

Comment 2 Filip Pizlo 2014-12-14 17:29:15 PST

Whoa I'm pretty sure that the patch is invalid.

Comment 3 Filip Pizlo 2014-12-14 17:29:39 PST

Created attachment 243275 [details]
the patch

That's better.

Comment 4 WebKit Commit Bot 2014-12-14 19:48:49 PST

Comment on attachment 243275 [details]
the patch

Clearing flags on attachment: 243275

Committed r177270: <http://trac.webkit.org/changeset/177270>

Comment 5 WebKit Commit Bot 2014-12-14 19:48:53 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Mark Lam 2014-12-15 11:22:35 PST

<rdar://problem/19245579>