Bug 139617

Summary: Implement Data Detectors immediate actions for WebKit2
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, conrad_shultz, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bdakin: review+

Tim Horton
Reported 2014-12-13 00:16:00 PST
Implement Data Detectors immediate actions for WebKit2
Attachments
Patch (15.66 KB, patch)
2014-12-13 00:16 PST, Tim Horton 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-12-13 00:16:56 PST
Created attachment 243251 [details] Patch
Tim Horton
Comment 2 2014-12-13 00:18:07 PST
<rdar://problem/19198539>
WebKit Commit Bot
Comment 3 2014-12-13 00:19:13 PST
Attachment 243251 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:464: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:466: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 4 2014-12-13 02:01:58 PST
Comment on attachment 243251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243251&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:3615 > + // FIXME: Temporarily disable action menu installation. This is pretty shameful.
Eric Carlson
Comment 5 2014-12-13 07:52:16 PST
Comment on attachment 243251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243251&action=review > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:93 > + _immediateActionRecognizer.enabled = NO; > + _immediateActionRecognizer.enabled = YES; See my comment in the WK1 version of this patch. > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:462 > + // Ref our WebPageProxy for use in the blocks below. > + RefPtr<WebPageProxy> page = _page; Nit: this seems fairly self evident, is the comment necessary?
Tim Horton
Comment 7 2014-12-15 12:27:37 PST
http://trac.webkit.org/changeset/177303
Note You need to log in before you can comment on or make changes to this bug.