Summary: | Implement Data Detectors immediate actions for WebKit2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, bdakin, commit-queue, conrad_shultz, eric.carlson, glenn, jer.noble, philipj, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2014-12-13 00:16:00 PST
Created attachment 243251 [details]
Patch
Attachment 243251 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:464: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:466: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:470: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 243251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243251&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:3615 > + // FIXME: Temporarily disable action menu installation. This is pretty shameful. Comment on attachment 243251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243251&action=review > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:93 > + _immediateActionRecognizer.enabled = NO; > + _immediateActionRecognizer.enabled = YES; See my comment in the WK1 version of this patch. > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:462 > + // Ref our WebPageProxy for use in the blocks below. > + RefPtr<WebPageProxy> page = _page; Nit: this seems fairly self evident, is the comment necessary? |