Bug 139609

Summary: [Mac] Work around a bug in dsymutil on older OS versions
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebCore Misc.Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, fpizlo, ggaren
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Mark Rowe (bdash) 2014-12-12 17:07:34 PST
The version of dsymutil that's part of the toolchain on older OS versions has a bug that limits the size of each architecture's slice of the dSYM file to 2GB (<rdar://problem/16045763>). WebCore is now exceeding that size, which causes dsymutil to fail to generate a dSYM bundle for WebCore, resulting in a build failure.

<rdar://problem/16045763>
Comment 1 Mark Rowe (bdash) 2014-12-12 17:16:33 PST
Created attachment 243235 [details]
Patch
Comment 2 Geoffrey Garen 2014-12-12 17:31:58 PST
Comment on attachment 243235 [details]
Patch

r=me
Comment 3 Mark Rowe (bdash) 2014-12-12 17:45:35 PST
Landed in <http://trac.webkit.org/changeset/177254>.
Comment 4 David Kilzer (:ddkilzer) 2014-12-12 19:48:09 PST
Comment on attachment 243235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243235&action=review

> Source/WebCore/Configurations/DebugRelease.xcconfig:41
> +CLANG_DEBUG_INFORMATION_LEVEL = default;

I'm not sure if this will work to override CLANG_DEBUG_INFORMATION_LEVEL from Base.xcconfig because the [sdk=] selector is more specific than this declaration.
Comment 5 David Kilzer (:ddkilzer) 2014-12-12 19:55:44 PST
(In reply to comment #4)
> Comment on attachment 243235 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243235&action=review
> 
> > Source/WebCore/Configurations/DebugRelease.xcconfig:41
> > +CLANG_DEBUG_INFORMATION_LEVEL = default;
> 
> I'm not sure if this will work to override CLANG_DEBUG_INFORMATION_LEVEL
> from Base.xcconfig because the [sdk=] selector is more specific than this
> declaration.

See discussion in Bug 139463 Comment #2.
Comment 6 Mark Rowe (bdash) 2014-12-12 23:16:44 PST
I tested it on OS X 10.9 and 10.10 and it gave the expected results. Which configuration do we expect to give the wrong outcome?
Comment 7 David Kilzer (:ddkilzer) 2014-12-13 03:41:13 PST
(In reply to comment #6)
> I tested it on OS X 10.9 and 10.10 and it gave the expected results. Which
> configuration do we expect to give the wrong outcome?

EWS bots are running 10.8, so probably that one.  :|

Oh, maybe this only happens when using $(inherited).  The issue I saw was with OTHER_LDFLAGS.