Bug 139573

Summary: Web Inspector: Crash when trying to inspect LocalStorage
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix andersca: review+

Description Joseph Pecoraro 2014-12-11 18:17:56 PST 
* SUMMARY
Crash trying to own LocalStorage view in Web Inspector.

* STEPS TO REPRODUCE
1. Inspect a page like twitter.com
2. Click "Local Storage" in Resources navigation sidebar
  => CRASH

* CRASH
Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000001036c36dd WebCore::InspectorDOMStorageAgent::findStorageArea(WTF::String&, WTF::RefPtr<Inspector::InspectorObject> const&, WebCore::Frame*&) + 269
1   com.apple.WebCore             	0x00000001036c3253 WebCore::InspectorDOMStorageAgent::getDOMStorageItems(WTF::String&, WTF::RefPtr<Inspector::InspectorObject> const&, WTF::RefPtr<Inspector::Protocol::Array<Inspector::Protocol::Array<WTF::String> > >&) + 51
2   com.apple.JavaScriptCore      	0x0000000102c6b726 Inspector::InspectorDOMStorageBackendDispatcher::getDOMStorageItems(long, Inspector::InspectorObject const&) + 438
3   com.apple.JavaScriptCore      	0x0000000102c6b29b Inspector::InspectorDOMStorageBackendDispatcher::dispatch(long, WTF::String const&, WTF::PassRefPtr<Inspector::InspectorObject>) + 139
4   com.apple.JavaScriptCore      	0x0000000102c4f61b Inspector::InspectorBackendDispatcher::dispatch(WTF::String const&) + 1723
Comment 1 Joseph Pecoraro 2014-12-11 18:19:18 PST 
Created attachment 243171 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-12-11 18:21:59 PST 
Attachment 243171 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:205:  Declaration has space between type name and * in Document *document  [whitespace/declaration] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2014-12-11 18:24:28 PST 
Comment on attachment 243171 [details]
[PATCH] Proposed Fix

Style issue, I'll land manually.
Comment 4 Joseph Pecoraro 2014-12-11 18:26:37 PST 
http://trac.webkit.org/changeset/177202