Bug 139567 – [iOS] Predictions are not updated when using navigation buttons

• Component: WebKit2
• Status: RESOLVED FIXED

[Enrica Casucci]

Predictions on top of the on screen keyboard are not updated when changing focus using the navigation buttons.
We need to notify the keyboard that the selection has changed so that it can update the prediction bar.

rdar://problem/19132585

[Enrica Casucci]

Created attachment 243161 [details]
Patch

[WebKit Commit Bot]

Attachment 243161 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:153:  Should have space between @property and attributes.  [whitespace/property] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:153:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:454:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:803:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 243161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243161&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1187
> +    return _formAccessoryView.get().buttonItems;

We normally don’t use dot syntax after get(), but instead prefer bracket syntax in this case.

I’m assuming it’s OK to call -buttonItems here without a runtime check, because this method will only be called if -buttonItems is defined. If I’m wrong, please add a -respondsToSelector check.

[Enrica Casucci]

(In reply to comment #3)
> Comment on attachment 243161 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243161&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1187
> > +    return _formAccessoryView.get().buttonItems;
> 
> We normally don’t use dot syntax after get(), but instead prefer bracket
> syntax in this case.
I will do as you suggested.
> 
> I’m assuming it’s OK to call -buttonItems here without a runtime check,
> because this method will only be called if -buttonItems is defined. If I’m
> wrong, please add a -respondsToSelector check.
Yes, it is OK.
Thanks for the review!

[Enrica Casucci]

Committed revision 177246.