Bug 139534

Summary: [SOUP] [GTK] warning: unused parameter at NetworkProcessSoup.cpp after r177056
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, koivisto, mrobinson, ossy, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Carlos Alberto Lopez Perez 2014-12-11 03:56:31 PST 
After 177056 <http://trac.webkit.org/r177056> when building WebKitGTK+ the following warnings happen:

[5015/5536] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/NetworkProcess/soup/NetworkProcessSoup.cpp.o
../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:75: warning: unused parameter 'modifiedSince' [-Wunused-parameter]
../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:113: warning: unused parameter 'completionHandler' [-Wunused-parameter]
Comment 1 Carlos Alberto Lopez Perez 2014-12-11 03:59:44 PST 
Created attachment 243112 [details]
Patch
Comment 2 Martin Robinson 2014-12-11 04:09:51 PST 
Comment on attachment 243112 [details]
Patch

Instead of unused parameter simply put the name of the parameter in comments like this:

void NetworkProcess::clearDiskCache(std::chrono::system_clock::time_point /* modifiedSince */, std::function<void ()> /* completionHandler */)
Comment 3 Carlos Alberto Lopez Perez 2014-12-11 04:25:35 PST 
Created attachment 243114 [details]
Patch
Comment 4 Carlos Alberto Lopez Perez 2014-12-11 05:36:35 PST 
Comment on attachment 243114 [details]
Patch

Clearing flags on attachment: 243114

Committed r177145: <http://trac.webkit.org/changeset/177145>
Comment 5 Carlos Alberto Lopez Perez 2014-12-11 05:36:42 PST 
All reviewed patches have been landed.  Closing bug.