Bug 139475

Summary: REGRESSION(r177038): [SOUP] [GTK] Debug build broken
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, commit-queue, gustavo, koivisto, ossy, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2014-12-10 03:39:34 PST 
Revision r177038 <http://trac.webkit.org/r177038> added a new method NetworkProcess::clearDiskCache() that only was implemented for MAC ports. This has caused build failures on the GTK Debug build: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/47106/steps/compile-webkit/logs/stdio
Comment 1 Carlos Alberto Lopez Perez 2014-12-10 03:49:23 PST 
Created attachment 243006 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-10 03:50:01 PST 
Attachment 243006 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-12-10 04:39:55 PST 
The commit-queue encountered the following flaky tests while processing attachment 243006 [details]:

The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2014-12-10 04:40:23 PST 
The commit-queue encountered the following flaky tests while processing attachment 243006 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 Carlos Alberto Lopez Perez 2014-12-10 04:49:40 PST 
Comment on attachment 243006 [details]
Patch

Committing manually.. cq seems borked
Comment 6 WebKit Commit Bot 2014-12-10 04:50:41 PST 
Comment on attachment 243006 [details]
Patch

Clearing flags on attachment: 243006

Committed r177056: <http://trac.webkit.org/changeset/177056>
Comment 7 WebKit Commit Bot 2014-12-10 04:50:45 PST 
All reviewed patches have been landed.  Closing bug.