Bug 139445

Summary:

Refactor of rebuildFloatingObjectSetFromIntrudingFloats function after r176957.

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

New Bugs

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, esprehn+autocc, glenn, hyatt, jfernandez, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
updated-patch	none

Description Javier Fernandez 2014-12-09 06:28:25 PST

Refactor of rebuildFloatingObjectSetFromIntrudingFloats function after r176957.

Comment 1 Javier Fernandez 2014-12-09 06:46:01 PST

Created attachment 242917 [details]
Patch

Comment 2 Javier Fernandez 2014-12-09 06:49:50 PST

This bug has been created to complete the changes suggested in the review of the patch for bug #139150.

Comment 3 Darin Adler 2014-12-09 07:33:39 PST

Comment on attachment 242917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242917&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:191
> +            if (!siblingBlock.avoidsFloats()) {
> +                previousBlock = &siblingBlock;
> +                break;
> +            }

This could just be:

    if (!siblingBlock.avoidFloats())
        return &siblingBlock;

Then we could get rid of the previousBlock local variable entirely.

Comment 4 Javier Fernandez 2014-12-09 08:12:25 PST

Created attachment 242922 [details]
updated-patch

Applied suggested changes.

Comment 5 WebKit Commit Bot 2014-12-09 09:44:04 PST

Comment on attachment 242922 [details]
updated-patch

Clearing flags on attachment: 242922

Committed r177021: <http://trac.webkit.org/changeset/177021>

Comment 6 WebKit Commit Bot 2014-12-09 09:44:08 PST

All reviewed patches have been landed.  Closing bug.