Bug 139445

Summary: Refactor of rebuildFloatingObjectSetFromIntrudingFloats function after r176957.
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: New BugsAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, hyatt, jfernandez, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
updated-patch none

Javier Fernandez
Reported 2014-12-09 06:28:25 PST
Refactor of rebuildFloatingObjectSetFromIntrudingFloats function after r176957.
Attachments
Patch (8.31 KB, patch)
2014-12-09 06:46 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
updated-patch (8.21 KB, patch)
2014-12-09 08:12 PST, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2014-12-09 06:46:01 PST
Created attachment 242917 [details] Patch
Javier Fernandez
Comment 2 2014-12-09 06:49:50 PST
This bug has been created to complete the changes suggested in the review of the patch for bug #139150.
Darin Adler
Comment 3 2014-12-09 07:33:39 PST
Comment on attachment 242917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242917&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:191 > + if (!siblingBlock.avoidsFloats()) { > + previousBlock = &siblingBlock; > + break; > + } This could just be: if (!siblingBlock.avoidFloats()) return &siblingBlock; Then we could get rid of the previousBlock local variable entirely.
Javier Fernandez
Comment 4 2014-12-09 08:12:25 PST
Created attachment 242922 [details] updated-patch Applied suggested changes.
WebKit Commit Bot
Comment 5 2014-12-09 09:44:04 PST
Comment on attachment 242922 [details] updated-patch Clearing flags on attachment: 242922 Committed r177021: <http://trac.webkit.org/changeset/177021>
WebKit Commit Bot
Comment 6 2014-12-09 09:44:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.