Summary: | [iOS] Safari crashes at -[_NSUndoStack popAndInvoke] when trying to undo typing on closed tab | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||
Component: | WebKit2 | Assignee: | mitz | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
mitz
2014-12-08 11:28:51 PST
Created attachment 242834 [details]
Give each WKWebContentView an undo manager
Should we do this on OS X as well? Should we do it on the WKWebVIew level instead? (In reply to comment #2) > Should we do this on OS X as well? I don’t know if this bug exists in OS X. The Legacy WebKit implementation of -undoManager differs between iOS and OS X. > Should we do it on the WKWebVIew level instead? I don’t know. This change appears to fix the bug as it is. (In reply to comment #3) > > Should we do it on the WKWebVIew level instead? > > I don’t know. This change appears to fix the bug as it is. OK. Do you think adding it to the content view instead of the WKWebView could cause any problems for people subclassing WKWebView and overriding -undoManager? (In reply to comment #4) > (In reply to comment #3) > > > > Should we do it on the WKWebVIew level instead? > > > > I don’t know. This change appears to fix the bug as it is. > > OK. Do you think adding it to the content view instead of the WKWebView > could cause any problems for people subclassing WKWebView and overriding > -undoManager? Functions in PageClientImplIOS.mm access the WKContentView’s undoManager property directly, so the implementation in the WKWebView subclass won’t be called. Fixed in <http://trac.webkit.org/r176969>. |