Bug 139401

Summary: Remove ResourceHandle::loadsBlocked()
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Description Anders Carlsson 2014-12-08 08:42:56 PST 
Remove ResourceHandle::loadsBlocked()
Comment 1 Anders Carlsson 2014-12-08 08:44:04 PST 
Created attachment 242814 [details]
Patch
Comment 2 Daniel Bates 2014-12-08 08:56:35 PST 
Comment on attachment 242814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242814&action=review

> Source/WebCore/page/Chrome.cpp:230
>      // If loads are blocked, we can't run modal because the contents
>      // of the modal dialog will never show up!

Is this comment still relevant? Notice that it was added when we added the conjunct "!ResourceHandle::loadsBlocked()" in <http://trac.webkit.org/changeset/17577>.
Comment 3 Anders Carlsson 2014-12-08 08:57:07 PST 
Committed r176949: <http://trac.webkit.org/changeset/176949>