Bug 139400 – [iOS] YouTube plug-in replacement should support partial urls

• Component: Media
• Status: RESOLVED FIXED

[Eric Carlson]

Some sites use urls that begin with just "//" for YouTube iFrames, so the YouTube plug-in replacement should support them.

[Eric Carlson]

Created attachment 242816 [details]
Proposed patch.

[Alexey Proskuryakov]

Comment on attachment 242816 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=242816&action=review

> Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:289
> +    if (srcString.startsWith("//"))
> +        srcURL = URL(URL(), "http:" + srcString);
> +    else
> +        srcURL = URL(URL(), srcString);

This does not look right, because for https pages, it should almost certainly use https, too.

I'm only guessing about what and Flash/YouTube do, my instinct is that we should use Document::completeURL to handle any relative URLs, not just those without a scheme.

[Eric Carlson]

(In reply to comment #2)
> Comment on attachment 242816 [details]
> Proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242816&action=review
> 
> > Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:289
> > +    if (srcString.startsWith("//"))
> > +        srcURL = URL(URL(), "http:" + srcString);
> > +    else
> > +        srcURL = URL(URL(), srcString);
> 
> This does not look right, because for https pages, it should almost
> certainly use https, too.
> 
> I'm only guessing about what and Flash/YouTube do, my instinct is that we
> should use Document::completeURL to handle any relative URLs, not just those
> without a scheme.

This is an excellent suggestion, thanks!

[Eric Carlson]

Created attachment 242845 [details]
Updated patch.

[WebKit Commit Bot]

Comment on attachment 242845 [details]
Updated patch.

Clearing flags on attachment: 242845

Committed r176977: <http://trac.webkit.org/changeset/176977>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.