Bug 13939

Summary:

[S60] 3.2 widget flag changes.

Product:

WebKit

Reporter:

Wei Liu <wei.liu>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Blocker

Keywords:

PlatformOnly

Priority:

Version:

523.x (Safari 3)

Hardware:

S60 Emulator

OS:

S60 3rd edition

Attachments:

Description	Flags
patch to remove old flag and use new flag, 3.2 only	Sachin.Padma: review-
patch to remove old flag and use new flag, 3.2 only	Sachin.Padma: review-
flag change for 3.2	Sachin.Padma: review-
widget flag changes.	Sachin.Padma: review+

Wei Liu

Reported 2007-05-30 13:04:09 PDT

Introduce the new static flag __WEB_WIDGETS and new dynamic feature flag KFeatureIdWebWidgets

Attachments
patch to remove old flag and use new flag, 3.2 only (35.95 KB, patch) 2007-05-30 13:40 PDT, Wei Liu	Sachin.Padma: review-	Details Formatted Diff Diff
patch to remove old flag and use new flag, 3.2 only (37.83 KB, patch) 2007-06-04 10:10 PDT, Wei Liu	Sachin.Padma: review-	Details Formatted Diff Diff
flag change for 3.2 (36.48 KB, patch) 2007-06-05 06:52 PDT, Wei Liu	Sachin.Padma: review-	Details Formatted Diff Diff
widget flag changes. (35.77 KB, patch) 2007-06-05 13:43 PDT, Wei Liu	Sachin.Padma: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Wei Liu

Comment 1 2007-05-30 13:40:42 PDT

Created attachment 14790 [details] patch to remove old flag and use new flag, 3.2 only

Sachin Padma

Comment 2 2007-05-31 13:49:34 PDT

Comment on attachment 14790 [details] patch to remove old flag and use new flag, 3.2 only Can you please remove the loadpluginssync function. I t is not needed

Wei Liu

Comment 3 2007-06-04 10:10:19 PDT

Created attachment 14853 [details] patch to remove old flag and use new flag, 3.2 only

Sachin Padma

Comment 4 2007-06-04 14:33:16 PDT

Comment on attachment 14853 [details] patch to remove old flag and use new flag, 3.2 only pluginsyncl function is still called

Wei Liu

Comment 5 2007-06-05 06:52:15 PDT

Created attachment 14863 [details] flag change for 3.2

Wei Liu

Comment 6 2007-06-05 07:03:03 PDT

HI Sachin, I don't understand why you were saying the the pluginssyncl is still called in my 2nd patch. It shows clearly it's removed. Anyway, I resubmitted my patch again,please check them out.

Sachin Padma

Comment 7 2007-06-05 12:39:18 PDT

Comment on attachment 14863 [details] flag change for 3.2 webkitcontrol.cpp removes deferanimation code

Wei Liu

Comment 8 2007-06-05 13:43:05 PDT

Created attachment 14870 [details] widget flag changes.

Sachin Padma

Comment 9 2007-06-05 13:49:23 PDT

Comment on attachment 14870 [details] widget flag changes. r=me

Sachin Padma

Comment 10 2007-06-05 13:50:19 PDT

landed in ccb in r21980

Bradley Morrison

Comment 11 2008-04-09 11:39:42 PDT

Bulk closing of all s60 platform bugs. Sorry for the noise!

Note You need to log in before you can comment on or make changes to this bug.