Summary: | Fix Build Warning in JavaScriptCore ControlFlowProfiler::dumpData() api | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shivakumar J M <shiva.jm> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, commit-queue, darin, fpizlo, gyuyoung.kim, mark.lam, oliver | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Shivakumar J M
2014-12-07 21:27:16 PST
Created attachment 242785 [details]
Patch
Fix Build Warning by using proper format argument for dataLogF() function.
might have casued by bug: https://bugs.webkit.org/show_bug.cgi?id=137785 Comment on attachment 242785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242785&action=review > Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp:58 > + dataLogF("SourceID: %d\n", iter->key); Looks like the EFL port disagrees with this fix. Out of curiosity, what port are you seeing this build warning on? FYI, instead, I think the better fix is to do: dataLog("SourceID: “, iter->key, “\n”); (In reply to comment #3) > Comment on attachment 242785 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242785&action=review > > > Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp:58 > > + dataLogF("SourceID: %d\n", iter->key); > > Looks like the EFL port disagrees with this fix. Out of curiosity, what > port are you seeing this build warning on? > > FYI, instead, I think the better fix is to do: > dataLog("SourceID: “, iter->key, “\n”); Dear Mark, I am using EFL port, in my local build machine i got these error, but i am usng g++-4.8, std=c++11, is it some thing do with setup? Thanks (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 242785 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=242785&action=review > > > > > Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp:58 > > > + dataLogF("SourceID: %d\n", iter->key); > > > > Looks like the EFL port disagrees with this fix. Out of curiosity, what > > port are you seeing this build warning on? > > > > FYI, instead, I think the better fix is to do: > > dataLog("SourceID: “, iter->key, “\n”); > > > Dear Mark, > > I am using EFL port, in my local build machine i got these error, but i > am usng g++-4.8, std=c++11, is it some thing do with setup? > > Thanks Probably something to do with your compiler/toolchain version or perhaps custom compiler flags that you are using (if any). Anyway, try the dataLog() version I suggested on the EWS bots. Every port should be happy with that. (In reply to comment #5) > (In reply to comment #4) > > I am using EFL port, in my local build machine i got these error, but i > > am usng g++-4.8, std=c++11, is it some thing do with setup? > > > > Thanks > > Probably something to do with your compiler/toolchain version or perhaps > custom compiler flags that you are using (if any). Or ... it’s probably a 32-bit vs 64-bit issue. But using dataLog() should take care of that. Created attachment 242787 [details]
Patch-Updated-Review1
Fix Build Warning by using dataLog() function instead of dataLogF() function.
Comment on attachment 242787 [details] Patch-Updated-Review1 View in context: https://bugs.webkit.org/attachment.cgi?id=242787&action=review > Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp:58 > + dataLog("SourceID: %ld\n", iter->key); This is wrong. dataLog() doesn’t take a format string. Instead, it should take a comma separated list or items to be printed. The correct way to do this is: dataLog(“SourceID: “, iter->key, “\n”); Created attachment 242871 [details]
Patch-Updated-Review1
Updated the patch to properly use dataLog() function.
Comment on attachment 242871 [details]
Patch-Updated-Review1
r=me
Comment on attachment 242871 [details] Patch-Updated-Review1 Clearing flags on attachment: 242871 Committed r177009: <http://trac.webkit.org/changeset/177009> All reviewed patches have been landed. Closing bug. |