Bug 139382 – Web Inspector: Clicking on the expand object arrow should always expand an object

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Created attachment 242778 [details]
Screencast

When object is not selected, clicking on the expand object arrow selects the object but doesn’t expand it.

[Radar WebKit Bug Importer]

<rdar://problem/19171607>

[Nikita Vasilyev]

Created attachment 242779 [details]
patch

[Nikita Vasilyev]

Created attachment 242780 [details]
patch

[Nikita Vasilyev]

Created attachment 242781 [details]
Patch

Sorry for spam, I don’t know how to make `Tools/Scripts/webkit-patch upload` send patches from [e-mail] instead of [e-mail].

[Joseph Pecoraro]

Comment on attachment 242781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242781&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-441
> -    _click: function(event)
> -    {
> -        if (!this._mouseInteractionShouldPreventClickPropagation)
> -            return;
> -
> -        event.stopPropagation();
> -        delete this._mouseInteractionShouldPreventClickPropagation;
> -    },

If you drag select a few Console rows, and then release the mouse on an Object expand arrow, does the object expand?

[Nikita Vasilyev]

(In reply to comment #5)
> Comment on attachment 242781 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242781&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-441
> > -    _click: function(event)
> > -    {
> > -        if (!this._mouseInteractionShouldPreventClickPropagation)
> > -            return;
> > -
> > -        event.stopPropagation();
> > -        delete this._mouseInteractionShouldPreventClickPropagation;
> > -    },
> 
> If you drag select a few Console rows, and then release the mouse on an
> Object expand arrow, does the object expand?

It doesn’t: https://cloudup.com/c7FMD7dKgZF. I believe, this is how it’s supposed to be.

[Nikita Vasilyev]

Created attachment 243324 [details]
Patch

Same patch after `git pull --rebase origin master`.

[Joseph Pecoraro]

Comment on attachment 243324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243324&action=review

r=me, though I wonder why this code was there originally.

> Source/WebInspectorUI/ChangeLog:10
> +        Web Inspector: Clicking on the expand object arrow should always expand an object
> +        https://bugs.webkit.org/show_bug.cgi?id=139382
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UserInterface/Views/LogContentView.js:
> +        (WebInspector.LogContentView):
> +        (WebInspector.LogContentView.prototype._click): Deleted.

Could use a comment about "why". In this case the click hander's stop propagation was preventing the object expansion from happening as expected.

[Nikita Vasilyev]

Created attachment 243331 [details]
Patch

Not sure if I use the right tense to describe the original (broken) behavior.

[WebKit Commit Bot]

Comment on attachment 243331 [details]
Patch

Clearing flags on attachment: 243331

Committed r177331: <http://trac.webkit.org/changeset/177331>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.