Bug 139382

Summary: Web Inspector: Clicking on the expand object arrow should always expand an object
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <me>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, me, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screencast
none
patch
none
patch
none
Patch
none
Patch
joepeck: review+, joepeck: commit-queue+
Patch none

Description Nikita Vasilyev 2014-12-07 18:59:29 PST
Created attachment 242778 [details]
Screencast

When object is not selected, clicking on the expand object arrow selects the object but doesn’t expand it.
Comment 1 Radar WebKit Bug Importer 2014-12-07 18:59:49 PST
<rdar://problem/19171607>
Comment 2 Nikita Vasilyev 2014-12-07 19:26:16 PST
Created attachment 242779 [details]
patch
Comment 3 Nikita Vasilyev 2014-12-07 19:45:15 PST
Created attachment 242780 [details]
patch
Comment 4 Nikita Vasilyev 2014-12-07 20:10:04 PST
Created attachment 242781 [details]
Patch

Sorry for spam, I don’t know how to make `Tools/Scripts/webkit-patch upload` send patches from nvasilyev@apple.com instead of me@elv1s.ru.
Comment 5 Joseph Pecoraro 2014-12-15 15:28:15 PST
Comment on attachment 242781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242781&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-441
> -    _click: function(event)
> -    {
> -        if (!this._mouseInteractionShouldPreventClickPropagation)
> -            return;
> -
> -        event.stopPropagation();
> -        delete this._mouseInteractionShouldPreventClickPropagation;
> -    },

If you drag select a few Console rows, and then release the mouse on an Object expand arrow, does the object expand?
Comment 6 Nikita Vasilyev 2014-12-15 15:45:07 PST
(In reply to comment #5)
> Comment on attachment 242781 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242781&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-441
> > -    _click: function(event)
> > -    {
> > -        if (!this._mouseInteractionShouldPreventClickPropagation)
> > -            return;
> > -
> > -        event.stopPropagation();
> > -        delete this._mouseInteractionShouldPreventClickPropagation;
> > -    },
> 
> If you drag select a few Console rows, and then release the mouse on an
> Object expand arrow, does the object expand?

It doesn’t: https://cloudup.com/c7FMD7dKgZF. I believe, this is how it’s supposed to be.
Comment 7 Nikita Vasilyev 2014-12-15 15:56:13 PST
Created attachment 243324 [details]
Patch

Same patch after `git pull --rebase origin master`.
Comment 8 Joseph Pecoraro 2014-12-15 16:41:22 PST
Comment on attachment 243324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243324&action=review

r=me, though I wonder why this code was there originally.

> Source/WebInspectorUI/ChangeLog:10
> +        Web Inspector: Clicking on the expand object arrow should always expand an object
> +        https://bugs.webkit.org/show_bug.cgi?id=139382
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UserInterface/Views/LogContentView.js:
> +        (WebInspector.LogContentView):
> +        (WebInspector.LogContentView.prototype._click): Deleted.

Could use a comment about "why". In this case the click hander's stop propagation was preventing the object expansion from happening as expected.
Comment 9 Nikita Vasilyev 2014-12-15 16:53:22 PST
Created attachment 243331 [details]
Patch

Not sure if I use the right tense to describe the original (broken) behavior.
Comment 10 WebKit Commit Bot 2014-12-15 19:24:26 PST
Comment on attachment 243331 [details]
Patch

Clearing flags on attachment: 243331

Committed r177331: <http://trac.webkit.org/changeset/177331>
Comment 11 WebKit Commit Bot 2014-12-15 19:24:29 PST
All reviewed patches have been landed.  Closing bug.