Bug 139375

Summary: Inline elements whose parents have small line-height are laid out too low
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, eoconnor, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, rniwa, simon.fraser, thorton, webkit-bug-importer, WebkitBugTracker
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Patch hyatt: review+

Myles C. Maxfield
Reported 2014-12-07 14:04:39 PST
Inline elements whose parents have small line-height are laid out too low
Attachments
Patch (362.48 KB, patch)
2014-12-07 14:12 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (540.13 KB, application/zip)
2014-12-07 15:14 PST, Build Bot 		no flags
Details
Patch (385.07 KB, patch)
2014-12-07 15:53 PST, Myles C. Maxfield 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-12-07 14:12:56 PST
Created attachment 242769 [details] Patch
Myles C. Maxfield
Comment 2 2014-12-07 14:14:46 PST
<rdar://problem/19053991>
Radar WebKit Bug Importer
Comment 3 2014-12-07 14:15:10 PST
<rdar://problem/19170410>
Build Bot
Comment 4 2014-12-07 15:13:59 PST
Comment on attachment 242769 [details] Patch Attachment 242769 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5602963707920384 New failing tests: fast/forms/search-vertical-alignment.html
Build Bot
Comment 5 2014-12-07 15:14:12 PST
Created attachment 242770 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Myles C. Maxfield
Comment 6 2014-12-07 15:48:53 PST
Looks like fast/forms/search-vertical-alignment.html has different behavior on the EWS bots and my Yosemite machine
Myles C. Maxfield
Comment 7 2014-12-07 15:53:49 PST
Created attachment 242772 [details] Patch
Myles C. Maxfield
Comment 8 2014-12-08 12:35:25 PST
<rdar://problem/19053991>
Dave Hyatt
Comment 9 2014-12-08 13:33:53 PST
Comment on attachment 242772 [details] Patch r=me
Dave Hyatt
Comment 10 2014-12-08 13:42:08 PST
I would consider changing the box-sizing test (2nd pixel result), since it does say all the boxes should look identical. Could be confusing for someone coming along later if they see the new results.
Myles C. Maxfield
Comment 11 2014-12-08 15:10:42 PST
http://trac.webkit.org/changeset/176978
Note You need to log in before you can comment on or make changes to this bug.