| Summary: | [GStreamer] Major cleanups of AudioDestination implementation | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sebastian Dröge (slomo) <slomo> | ||||||||||||
| Component: | Media | Assignee: | Sebastian Dröge (slomo) <slomo> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Minor | CC: | commit-queue | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Sebastian Dröge (slomo)
2014-12-07 10:28:52 PST
Created attachment 242753 [details]
Patch
Attachment 242753 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This style error was there before, what do you suggest for fixing this? It's not clear to me what the style guide recommends for cases like this. Created attachment 242756 [details]
Patch
Created attachment 242763 [details]
Patch
Created attachment 242767 [details]
Patch
Comment on attachment 242763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242763&action=review > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:66 > + guint64 numSamples; We usually try to avoid abbreviations in variable names. I don't have many suggestions, I'm bad at naming stuff :) I could call it numberOfSamples if you prefer that :) Should I change it or is it ok like that? Created attachment 242789 [details]
Patch
Comment on attachment 242789 [details] Patch Clearing flags on attachment: 242789 Committed r176943: <http://trac.webkit.org/changeset/176943> All reviewed patches have been landed. Closing bug. |