Summary: | Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Page Loading | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, gyuyoung.kim, japhet, koivisto, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 139263 | ||||||||
Attachments: |
|
Description
Chris Dumez
2014-12-06 20:50:34 PST
Created attachment 242732 [details]
Patch
Comment on attachment 242732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242732&action=review > Source/WebCore/loader/FrameLoader.cpp:2160 > + default: > + return CachePolicyVerify; > + } It would be better to list all cases rather than use default. Created attachment 242823 [details]
Patch
Comment on attachment 242823 [details] Patch Clearing flags on attachment: 242823 Committed r176953: <http://trac.webkit.org/changeset/176953> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Comment on attachment 242823 [details] > Patch > > Clearing flags on attachment: 242823 > > Committed r176953: <http://trac.webkit.org/changeset/176953> It broke the EFL build, because gcc need some love - an unreachable return. I'm wondering why EFL EWS didn't notice this warning ... ../../Source/WebCore/loader/FrameLoader.cpp: In member function ‘WebCore::CachePolicy WebCore::FrameLoader::subresourceCachePolicy() const’: ../../Source/WebCore/loader/FrameLoader.cpp:2167:1: error: control reaches end of non-void function [-Werror=return-type] } ^ Fix is coming. Fix landed in https://trac.webkit.org/changeset/176958 |