Bug 139338

Summary: [WinCairo] Compile error, missing guard.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, benjamin, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description peavo 2014-12-06 03:59:23 PST
There is missing a ENABLE(CSS_SELECTORS_LEVEL4) guard in CSSParser.cpp.
Comment 1 peavo 2014-12-06 04:03:00 PST
Created attachment 242708 [details]
Patch
Comment 2 Alex Christensen 2014-12-06 09:45:16 PST
Comment on attachment 242708 [details]
Patch

That happens. Why is wincairo the only port noticing this?
Comment 3 WebKit Commit Bot 2014-12-06 10:25:33 PST
Comment on attachment 242708 [details]
Patch

Clearing flags on attachment: 242708

Committed r176907: <http://trac.webkit.org/changeset/176907>
Comment 4 WebKit Commit Bot 2014-12-06 10:25:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2014-12-06 12:11:24 PST
(In reply to comment #2)
> Comment on attachment 242708 [details]
> Patch
> 
> That happens. Why is wincairo the only port noticing this?

Thanks for reviewing :)

Maybe we should enable CSS_SELECTORS_LEVEL4, to avoid more of these compile errors?
Comment 6 Alex Christensen 2014-12-06 12:18:37 PST
Maybe we should completely remove the flag if everybody else has it enabled. Ben, what do you think?