Summary: | [WinCairo] Compile error, missing guard. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | peavo | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alex.christensen, benjamin, bfulgham, commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
peavo
2014-12-06 03:59:23 PST
Created attachment 242708 [details]
Patch
Comment on attachment 242708 [details]
Patch
That happens. Why is wincairo the only port noticing this?
Comment on attachment 242708 [details] Patch Clearing flags on attachment: 242708 Committed r176907: <http://trac.webkit.org/changeset/176907> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > Comment on attachment 242708 [details] > Patch > > That happens. Why is wincairo the only port noticing this? Thanks for reviewing :) Maybe we should enable CSS_SELECTORS_LEVEL4, to avoid more of these compile errors? Maybe we should completely remove the flag if everybody else has it enabled. Ben, what do you think? |