Bug 139305

Summary:

Removed the custom allocator for ParserArena

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review-

Description Geoffrey Garen 2014-12-05 10:29:23 PST

Removed the custom allocator for ParserArena

Comment 1 Geoffrey Garen 2014-12-05 10:33:52 PST

Created attachment 242642 [details]
Patch

Comment 2 Michael Saboff 2014-12-05 10:42:17 PST

Comment on attachment 242642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242642&action=review

r=me

> Source/JavaScriptCore/ChangeLog:24
> +        pools anymore, since wej ust call malloc/free directly.

Typo "wej ust" should be "we just"

Comment 3 Geoffrey Garen 2014-12-05 14:08:44 PST

Comment on attachment 242642 [details]
Patch

Actually, it looks like I started with an incorrect baseline.

This patch is a 1% regression on JSBench if you run with the parsing cache disabled, and a 2% regression on Octane2-CodeLoad. So, there is a slight advantage to an explicit arena in this case.

Comment 4 Geoffrey Garen 2014-12-05 14:12:06 PST

I landed the removal of reset() in <https://trac.webkit.org/changeset/176871>.