Bug 139273

Summary: Split out FunctionNode from FunctionBodyNode
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Geoffrey Garen 2014-12-04 15:27:20 PST 
Split out FunctionNode from FunctionBodyNode
Comment 1 Geoffrey Garen 2014-12-04 15:37:03 PST 
Created attachment 242591 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-04 15:38:49 PST 
Attachment 242591 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:267:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-12-04 15:46:17 PST 
Comment on attachment 242591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242591&action=review

r=me

> Source/JavaScriptCore/parser/Nodes.h:1541
> +    class FunctionBodyNode : public StatementNode, public ParserArenaDeletable {

This class can be final.

> Source/JavaScriptCore/parser/Nodes.h:1585
> +    class FunctionNode : public ScopeNode {

Ditto.
Comment 4 Geoffrey Garen 2014-12-04 15:47:17 PST 
Committed r176822: <http://trac.webkit.org/changeset/176822>