Bug 139265 – [MSE] Add support for SourceBuffer.mode.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[MSE] Add support for SourceBuffer.mode.

[Jer Noble]

Created attachment 242650 [details]
Patch

[Bartlomiej Gajda]

Comment on attachment 242650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242650&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:126
>      , m_highestPresentationEndTimestamp(MediaTime::invalidTime())

This shall be removed, if You want to introduce groupStartTime - You should do it completely in one batch, as it was renamed in standard. I had bug https://bugs.webkit.org/show_bug.cgi?id=139040 which I'll mark as duplicate of this, if You do it all in one batch. I don't see any reason not to.

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1270
>              // Set group start timestamp equal to the highest presentation end timestamp.

Should be: "Set group start timestamp equal to the group end timestamp."

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1271
> +            m_groupStartTimestamp = m_highestPresentationEndTimestamp;

should use groupEndtimestamp

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1462
>          if (m_highestPresentationEndTimestamp.isInvalid() || frameEndTimestamp > m_highestPresentationEndTimestamp)

Above this should be : If frame end timestamp is greater than group end timestamp, then set group end timestamp equal to frame end timestamp.
And this line should be only second expression renamed. (since it's set to 0 by standard anyway)

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1463
>              m_highestPresentationEndTimestamp = frameEndTimestamp;

Should use m_groupEndTimestamp, also on 1428 with setDurationInternal

> Source/WebCore/Modules/mediasource/SourceBuffer.h:207
>      MediaTime m_highestPresentationEndTimestamp;

Should remove this.

[Jer Noble]

(In reply to comment #2)
> Comment on attachment 242650 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242650&action=review
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:126
> >      , m_highestPresentationEndTimestamp(MediaTime::invalidTime())
> 
> This shall be removed, if You want to introduce groupStartTime - You should
> do it completely in one batch, as it was renamed in standard. I had bug
> https://bugs.webkit.org/show_bug.cgi?id=139040 which I'll mark as duplicate
> of this, if You do it all in one batch. I don't see any reason not to.

Good point. I'll update the patch with these changes.

> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1270
> >              // Set group start timestamp equal to the highest presentation end timestamp.
> 
> Should be: "Set group start timestamp equal to the group end timestamp."
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1271
> > +            m_groupStartTimestamp = m_highestPresentationEndTimestamp;
> 
> should use groupEndtimestamp
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1462
> >          if (m_highestPresentationEndTimestamp.isInvalid() || frameEndTimestamp > m_highestPresentationEndTimestamp)
> 
> Above this should be : If frame end timestamp is greater than group end
> timestamp, then set group end timestamp equal to frame end timestamp.
> And this line should be only second expression renamed. (since it's set to 0
> by standard anyway)
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1463
> >              m_highestPresentationEndTimestamp = frameEndTimestamp;
> 
> Should use m_groupEndTimestamp, also on 1428 with setDurationInternal
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.h:207
> >      MediaTime m_highestPresentationEndTimestamp;
> 
> Should remove this.

[Jer Noble]

Created attachment 242873 [details]
Patch

[Bartlomiej Gajda]

*** Bug 139040 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 242873 [details]
Patch

Clearing flags on attachment: 242873

Committed r177225: <http://trac.webkit.org/changeset/177225>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jer Noble]

<rdar://problem/19269069>