Bug 139240

Summary: Implement action menus for tel: URLs
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Tim Horton
Reported 2014-12-03 16:20:56 PST
Implement action menus for tel: URLs
Attachments
Patch (10.26 KB, patch)
2014-12-03 16:21 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-12-03 16:21:31 PST
Created attachment 242537 [details] Patch
WebKit Commit Bot
Comment 2 2014-12-03 16:23:50 PST
Attachment 242537 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:310: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:311: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebActionMenuController.mm:312: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:870: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:871: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:872: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-12-03 16:32:59 PST
http://trac.webkit.org/changeset/176763
Tim Horton
Comment 4 2014-12-03 18:28:53 PST
And http://trac.webkit.org/changeset/176775
Tim Horton
Comment 5 2014-12-03 18:33:14 PST
And http://trac.webkit.org/changeset/176777
Note You need to log in before you can comment on or make changes to this bug.